[release/9.0] Fix WM_DESTROY message handling in ActiveX control #12659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix WM_DESTROY message handling * modified condition
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/9.0 #12659 +/- ##
=====================================================
+ Coverage 74.83047% 74.83066% +0.00018%
=====================================================
Files 3022 3022
Lines 630258 630259 +1
Branches 46794 46794
=====================================================
+ Hits 471625 471627 +2
+ Misses 155253 155249 -4
- Partials 3380 3383 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Verified the issue on latest .NET SDK 9.0.200-preview.0.24611.4 + private dlls built from Epica3055:BackPortPR12564And12648To9.0 branch, the issue has been fixed and no new regression issue found. Test result is like below. |
Tanya-Solyanik
changed the title
Tanya-Solyanik
added
🚫 * NO-MERGE *
Tanya-Solyanik
approved these changes
Dec 21, 2024
Tanya-Solyanik
added
Servicing-approved
|
Verified the issue with 9.0.0 + private dlls built from release/9.0 branch, the issue has been fixed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BackPort PR #12564 And #12648 To 9.0
Fixes #12551
Customer Impact
Parent container control is not sending WM_DESTROY message to the child control while disposing the ActiveX child controls. ActixeX child expects a WM_DESTORY message, but the message handler is never called.
Regression
Yes. Due to Move from IntPtr to nint to avoid runtime casting errors. (#5791) · dotnet/winforms@834d0a0, We accidentally removed caching of a window handle before destroying it, once the handle was destroyed, we were not able to forward message to its winproc.
Testing
Manual testing with the user-provided project
Risk
Low - The change reverts logic to .NET7 state, no workaround is possible