-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add hover visual effect for Popup button #13891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add hover visual effect for Popup button #13891
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds hover visual effects for Popup buttons in dark mode by implementing distinct rendering states for normal, hover (hot), and pressed button states.
Key changes:
- Enhanced the pressed state with deeper shadows and brighter highlights for better visual depth
- Added a new hover (hot) state that provides intermediate visual feedback between normal and pressed states
- Updated comments to clarify the visual effects for each button state
...System/Windows/Forms/Controls/Buttons/ButtonInternal/DarkMode/PopupButtonDarkModeRenderer.cs
Outdated
Show resolved
Hide resolved
e879dd0
to
c67a19b
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #13891 +/- ##
===================================================
- Coverage 77.16116% 77.14038% -0.02079%
===================================================
Files 3273 3274 +1
Lines 644919 645050 +131
Branches 47694 47702 +8
===================================================
- Hits 497627 497594 -33
- Misses 143607 143779 +172
+ Partials 3685 3677 -8
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question:
You had your MP4s shown under "Before" and "After" in your PR description. That would be wrong. But I think you increased the contrast.
Is it rather "Hover" and "Pressed" instead of that?
If that's a case, could you show all 4 versions?
- Pressed - Before/After
- Hover - Before/After
Thanks!
I updated the description. The visual change is clearer when the button has a background color. |
Fixes #13882
Proposed changes
Customer Impact
Regression?
Risk
Screenshots
Before
Hover on the button:
Hover-beforeChanges.mp4
Press the button:
Press-BeforeChanges.mp4
After
Hover on the button:
Hover-AfterChanges.mp4
Press the button:
Pressed-AfterChanges.mp4
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow