Add unit tests for ToolStripKeyboardHandlingService.cs file #13896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #13896 +/- ##
===================================================
+ Coverage 77.16116% 77.16767% +0.00651%
===================================================
Files 3273 3277 +4
Lines 644919 645164 +245
Branches 47694 47706 +12
===================================================
+ Hits 497627 497858 +231
- Misses 143607 143627 +20
+ Partials 3685 3679 -6
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
LeafShi1
reviewed
Sep 26, 2025
....Design/tests/UnitTests/System/Windows/Forms/Design/ToolStripKeyboardHandlingServiceTests.cs
Outdated
Show resolved
Hide resolved
| { | ||
| TemplateNodeActive = false | ||
| }; | ||
| service.OnContextMenu(10, 10).Should().BeFalse(); |
There was a problem hiding this comment.
The actual part of the OnContextMenu method is not tested.
ricardobossan
previously approved these changes
Sep 26, 2025
There was a problem hiding this comment.
All LGTM! Please consider initializing ToolStripKeyboardHandlingService once in the constructor instead of recreating it in every test. This would also allow converting some methods into expression-bodied members. When needed, you can adjust TemplateNodeActive after the service is instantiated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #10773
Proposed changes
Microsoft Reviewers: Open in CodeFlow