Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IBrowserHostServices/INativeProgressPage and cleanup AppSecurityManager #10220

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

h3xds1nz
Copy link
Contributor

@h3xds1nz h3xds1nz commented Jan 3, 2025

Description

Another batch of XBAP-related code removal; continues #9865 and previous PRs.

  • Removes IBrowserHostServices fully as it now had 1 unused enum left and that was it.
  • Removes INativeProgressPage and it was used in XappLauncherApp which is no longer present.
  • Removes IsAllowedScriptScheme function in WebBrowserEvent.
    • This is not part of the interface, and the calling code was removed when transitioning to .NET Core.
  • Cleans up the code in AppSecurityManager and removes the obsolete method overloads.
  • Sealed the SiteOfOriginContainer class
    • Cleans up comments/regions (suddenly the file is readable)
    • Put BooleanSwitch behind property, make it readonly
  • Regarding AppDomain.CurrentDomain.BaseDirectory change:
    • Since there are no AppDomains on .NET Core, CurrentDomain is a singleton and the BaseDirectory property just redirects to AppContext.BaseDirectory. As part of ongoing effort, I've replaced it here.

Customer Impact

Decreased size of assemblies, tiny bit of perf, cleaner codebase for developers.

Regression

No.

Testing

Local build, app run.

Risk

Low, the code is a dead code or it doesn't do anything.

Microsoft Reviewers: Open in CodeFlow

@h3xds1nz h3xds1nz requested review from a team as code owners January 3, 2025 17:47
@dotnet-policy-service dotnet-policy-service bot added PR metadata: Label to tag PRs, to facilitate with triage Community Contribution A label for all community Contributions labels Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution A label for all community Contributions PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant