Remove obsolete PreSharp warning suppressions #10221
Open
+453
−2,822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
requested review from
dipeshmsft,
singhashish-wpf and
Kuldeep-MS
dotnet-policy-service
bot
added
PR
|
@harshit7962 This would be good to get in, there are no code changes whatsoever. |
|
Yeah, this likely does not need a test pass. Will go through the changes and merge it directly. |
h3xds1nz
force-pushed
the
presharp-warnings
branch
from
5169bde to
f09154c
Compare
|
@harshit7962 I've pushed up the conflicts resolution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Similarly to #9903, remove obsolete warning suppressions, this time from PreSharp. This includes suppressions about unknown warning numbers and also the disable occurences of PreSharp-specific warnings.
Customer Impact
Cleaner codebase for developers.
Regression
No.
Testing
Local build.
Risk
None.
Microsoft Reviewers: Open in CodeFlow