ActiveRectangle height in ListView to match TreeView and WinUI #11030
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the ActiveRectangle height in ListView controls from 18 to 16 pixels to achieve visual consistency with TreeView controls and WinUI design standards.
Key Changes:
- Reduced ActiveRectangle height from 18 to 16 pixels across ListView templates
- Applied changes to both standard and GridView ListView item templates
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Themes/Fluent.xaml | Updates ActiveRectangle height in two ListView item control templates |
| src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Styles/ListViewItem.xaml | Updates ActiveRectangle height in ListView item style templates |
dotnet-policy-service
bot
added
PR
|
@dotnet-policy-service agree |
|
@cdock1029, can you run the script |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The TreeView ActiveRectangle is 16. The WinUI Gallery and Windows Settings apps both seem to show ListViews with this size rectangle. The WPF ListView ActiveRectangle height should match up with all of these other ones, currently it looks different from the others.
Customer Impact
Inconsistent UI
Testing
Nothing really, just changed all places I could see that were defined too tall.
Risk
Microsoft Reviewers: Open in CodeFlow