Fix validation adorner race condition (#8969) #11191
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a race condition where the validation adorner (red border) remains visible even after errors are cleared programmatically. This occurred when the adorner layer didn't exist during error occurrence, causing a delayed dispatcher operation to show the adorner using stale state. The fix ensures the current error state is always checked when the dispatcher operation executes, preventing the adorner from being shown for errors that have already been cleared.
dotnet-policy-service
bot
added
PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a race condition where the validation adorner (red border) remains visible even after errors are cleared programmatically. This occurred when the adorner layer didn't exist during error occurrence, causing a delayed dispatcher operation to show the adorner using stale state.
Fixes #8969
Microsoft Reviewers: Open in CodeFlow