Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use 1ESTemplate build #2435

Merged
merged 4 commits into from
Mar 19, 2024
Merged

Use 1ESTemplate build #2435

merged 4 commits into from
Mar 19, 2024

Conversation

benjaminpetit
Copy link
Member

No description provided.

@MihaZupan
Copy link
Member

Shouldn't we keep the original pipeline for public builds and have the one using the official template only be used for internal ones?

@benjaminpetit
Copy link
Member Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

MihaZupan
MihaZupan approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member

@MihaZupan MihaZupan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this.
Will we have to port this to release/* branches as well once it's merged?

@MihaZupan MihaZupan added this to the v.Next milestone Mar 18, 2024
@benjaminpetit
Copy link
Member Author

Thank you for working on this. Will we have to port this to release/* branches as well once it's merged?

Correct

@benjaminpetit benjaminpetit enabled auto-merge (squash) March 19, 2024 14:03
@benjaminpetit benjaminpetit merged commit 1ccfa12 into dotnet:main Mar 19, 2024
7 checks passed
benjaminpetit added a commit to benjaminpetit/reverse-proxy that referenced this pull request Mar 19, 2024
@benjaminpetit
Use 1ESTemplate build (dotnet#2435)
5cb2642
benjaminpetit added a commit that referenced this pull request Mar 19, 2024
@benjaminpetit
Backport 1ESTemplate to release/2.1 (#2442)
cf4923c 
* Use 1ESTemplate build (#2435)

* Import latest arcade changes
benjaminpetit added a commit to benjaminpetit/reverse-proxy that referenced this pull request Mar 20, 2024
@benjaminpetit
Backport 1ESTemplate to release/2.0
b70a40b 
* Use 1ESTemplate build (dotnet#2435)

* Import latest arcade changes
@benjaminpetit benjaminpetit mentioned this pull request Mar 20, 2024
Merged
benjaminpetit added a commit that referenced this pull request Mar 20, 2024
@benjaminpetit
Backport 1ESTemplate to release/2.0 (#2443)
af263d1 
* Use 1ESTemplate build (#2435)

* Import latest arcade changes
@MihaZupan MihaZupan added the Type: Infrastructure Infrastructure work that does not affect the actual shipping code label Mar 25, 2024
@MihaZupan MihaZupan modified the milestones: v.Next, YARP 2.2.0-preview1 May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MihaZupan MihaZupan MihaZupan approved these changes

@Tratcher Tratcher Awaiting requested review from Tratcher

Assignees
No one assigned
Labels
Type: Infrastructure Infrastructure work that does not affect the actual shipping code
Projects
None yet
Milestone
YARP 2.2.0-preview1
Development

Successfully merging this pull request may close these issues.
2 participants
@benjaminpetit @MihaZupan