Update KubernetesIngress docker builds #2446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminpetit
force-pushed
the
sample/k8s-docker
branch
from
33627d6 to
2dfab21
Compare
MihaZupan
approved these changes
Mar 20, 2024
|
-c Release is now the default with DotNet publish in .Net 8 |
Better to be explicit :) |
WeihanLi
reviewed
Mar 28, 2024
| WORKDIR /app | ||
| EXPOSE 80 | ||
| EXPOSE 443 | ||
|
|
||
| FROM amd64/buildpack-deps:jammy-curl AS publish | ||
| FROM mcr.microsoft.com/dotnet/sdk:8.0 AS publish |
There was a problem hiding this comment.
Since we install dotnet sdk via dotnet-install script, do we still need to use sdk image as base image?
There was a problem hiding this comment.
Good question, we still need to install the SDK because we target versions that are not published in docker.
The SDK docker image contains dependencies needed for the dotnet script to run properly.
MihaZupan
added
the
Type: Infrastructure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.