fix(#1583): Call AbandonMessageAsync on Azure Service Bus message when persistence fails to avoid message loss

[oussama-smida]

Description:

When using Azure Service Bus, messages are marked as completed even if the system fails to persist the received message to the database.

Issue(s) addressed:

• Azure Service Bus Messages Marked as Completed Even When Persistence Fails

Changes:

• Call AbandonMessageAsync on Azure Service Bus message when persistence fails to avoid message loss.

Affected components:

• DotNetCore.CAP.AzureServiceBus

Checklist:

• I have tested my changes locally
• I have added necessary documentation (if applicable)
• I have updated the relevant tests (if applicable)
• My changes follow the project's code style guidelines

[mviegas]

MS Docs have the following remark about the AutoCompleteMessages property of the SB processor:

If the message handler triggers an exception and did not settle the message, then the message will be automatically abandoned, irrespective of AutoCompleteMessages.

Still, what you proposed here makes sense as the OnMessageCallback catches exceptions, which causes the processor to think that messages were handled successfully.

LGTM.