Merge pull request #491 from Memoyu/fix-warning

Fix some CI warning
dotnetcore · Sep 19, 2023 · 7fd69b7 · 7fd69b7
2 parents a39a5bf + c34e22e
commit 7fd69b7
Show file tree

Hide file tree

Showing 6 changed files with 5 additions and 46 deletions.
diff --git a/bus/EasyCaching.Bus.RabbitMQStream/DefaultRabbitMQStreamBus.cs b/bus/EasyCaching.Bus.RabbitMQStream/DefaultRabbitMQStreamBus.cs
@@ -62,6 +62,7 @@ public class DefaultRabbitMQStreamBus : EasyCachingAbstractBus
         /// <param name="objectPolicy">Object policy.</param>
         /// <param name="rabbitMQOptions">RabbitMQ Options.</param>
         /// <param name="serializer">Serializer.</param>
+        /// <param name="logger">Logger.</param>
         public DefaultRabbitMQStreamBus(
             IPooledObjectPolicy<IModel> objectPolicy
             , IOptions<RabbitMQBusOptions> rabbitMQOptions

diff --git a/sample/EasyCaching.Demo.Locks/Controllers/LocksController.cs b/sample/EasyCaching.Demo.Locks/Controllers/LocksController.cs
@@ -30,7 +30,7 @@ public async Task DistributedLockingOperation(int millisecondsTimeout)
         catch (Exception ex)
         {
             // log error
-            throw;
+            throw new Exception("Exception", ex);
         }
         finally
         {
@@ -59,7 +59,7 @@ public async Task MemoryLockingOperation(int millisecondsTimeout)
         catch (Exception ex)
         {
             // log error
-            throw;
+            throw new Exception("Exception", ex);
         }
         finally
         {

diff --git a/src/EasyCaching.LiteDB/EasyCaching.LiteDB.csproj b/src/EasyCaching.LiteDB/EasyCaching.LiteDB.csproj
@@ -35,7 +35,7 @@
 	</ItemGroup>
 	<ItemGroup>
 		<PackageReference Include="LiteDB" Version="5.0.13" />
-		<PackageReference Include="Newtonsoft.Json" Version="12.0.3" />
+		<PackageReference Include="Newtonsoft.Json" Version="13.0.1" />
 		<PackageReference Include="Microsoft.CSharp" Version="4.7.0" />
 	</ItemGroup>
 </Project>
diff --git a/test/EasyCaching.UnitTests/CachingTests/FasterKvCachingProviderTest.cs b/test/EasyCaching.UnitTests/CachingTests/FasterKvCachingProviderTest.cs
@@ -76,17 +76,6 @@ protected override void Get_Parallel_Should_Succeed()
     {
     }
 
-    public override Task GetAllByPrefix_Async_Should_Throw_ArgumentNullException_When_Prefix_IsNullOrWhiteSpace(
-        string preifx)
-    {
-        return Task.CompletedTask;
-    }
-
-    public override void GetAllByPrefix_Should_Throw_ArgumentNullException_When_CacheKey_IsNullOrWhiteSpace(
-        string prefix)
-    {
-    }
-
     protected override Task Get_Count_Async_With_Prefix_Should_Succeed()
     {
         return Task.CompletedTask;
@@ -132,31 +121,10 @@ protected override void GetExpiration_Should_Succeed()
     {
     }
 
-    public override void RemoveByPattern_Should_Succeed()
-    {
-    }
-
-    public override Task RemoveByPatternAsync_Should_Succeed()
-    {
-        return Task.CompletedTask;
-    }
-
-    public override Task RemoveByPrefix_Async_Should_Throw_ArgumentNullException_When_Prefix_IsNullOrWhiteSpace(
-        string preifx)
-
-    {
-        return Task.CompletedTask;
-    }
-
     protected override void RemoveByPrefix_Should_Succeed()
     {
     }
 
-    public override void RemoveByPrefix_Should_Throw_ArgumentNullException_When_CacheKey_IsNullOrWhiteSpace(
-        string prefix)
-    {
-    }
-
     protected override Task RemoveByPrefixAsync_Should_Succeed()
     {
         return Task.CompletedTask;

diff --git a/test/EasyCaching.UnitTests/CachingTests/MemcachedProviderTest.cs b/test/EasyCaching.UnitTests/CachingTests/MemcachedProviderTest.cs
@@ -115,17 +115,6 @@ protected override void GetByPrefix_Should_Succeed()
         {
         }
 
-        [Fact]
-        public override void RemoveByPattern_Should_Succeed()
-        {
-        }
-
-        [Fact]
-        public override async Task RemoveByPatternAsync_Should_Succeed()
-        {
-            await Task.FromResult(1);
-        }
-
         [Fact]
         protected override async Task GetByPrefixAsync_Should_Succeed()
         {

diff --git a/test/EasyCaching.UnitTests/SerializerTests/MemoryPackSerializerTest.cs b/test/EasyCaching.UnitTests/SerializerTests/MemoryPackSerializerTest.cs
@@ -14,6 +14,7 @@ public MemoryPackSerializerTest()
     }
 
     //This should be overrided becuse it is not supported by memory-pack
+    [Fact]
     public override void DeserializeObject_should_Succeed()
     {
         Person input = new("test", "test1");
-Original file line number
+Diff line change
@@ Expand Up / @@ -14,6 +14,7 @@ public MemoryPackSerializerTest() @@
         }
         //This should be overrided becuse it is not supported by memory-pack
+        [Fact]
         public override void DeserializeObject_should_Succeed()
         {
             Person input = new("test", "test1");
@@ Expand Down @@