Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a script to automatically set the version in Cargo.toml #111

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

rlouf
Copy link
Member

@rlouf rlouf commented Dec 6, 2024

Closes #106. Failures are expected, but show that the script is working. I'll remove the Make release workflows run in CI commit before merging`, and will cut a new release afterwards to make sure this works.

@rlouf rlouf added the CI label Dec 6, 2024
@rlouf rlouf force-pushed the cargo-version-bumper branch 6 times, most recently from a9d667c to 5952864 Compare December 6, 2024 21:17
@rlouf rlouf self-assigned this Dec 9, 2024
@rlouf rlouf force-pushed the cargo-version-bumper branch 2 times, most recently from bfa1ff5 to cbc8696 Compare December 9, 2024 13:58
@rlouf rlouf requested a review from torymur December 9, 2024 13:59
@rlouf rlouf force-pushed the cargo-version-bumper branch from cbc8696 to 1e9850e Compare December 9, 2024 14:01
@rlouf rlouf requested review from torymur and removed request for torymur December 9, 2024 18:02
torymur
torymur previously approved these changes Dec 9, 2024
Copy link
Contributor

@torymur torymur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The extra dot and the style seems to be still hanging, otherwise looking forward to zero manual bumps 🤞

@rlouf rlouf force-pushed the cargo-version-bumper branch 2 times, most recently from 9fec454 to 23c1c17 Compare December 9, 2024 19:41
@rlouf rlouf force-pushed the cargo-version-bumper branch from 23c1c17 to c9ab7af Compare December 9, 2024 19:41
@rlouf rlouf merged commit 18dfb8b into dottxt-ai:main Dec 9, 2024
6 checks passed
@rlouf rlouf deleted the cargo-version-bumper branch December 9, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically set the version number in Cargo.toml in releases
2 participants