Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove JSON Schema conversion tests ported to Rust #118

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

rlouf
Copy link
Member

@rlouf rlouf commented Dec 9, 2024

Some of the tests for the JSON Schema conversion have been re-written in Rust #98. This PR removes the Python tests that were converted.

@rlouf rlouf self-assigned this Dec 9, 2024
@rlouf rlouf requested a review from torymur December 9, 2024 12:36
@torymur
Copy link
Contributor

torymur commented Dec 9, 2024

All mentioned tests were ported in this PR: #98

Copy link
Contributor

@torymur torymur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@rlouf rlouf merged commit d9adaa4 into dottxt-ai:main Dec 9, 2024
6 checks passed
@rlouf rlouf deleted the remove-unnecessary-python-tests branch December 9, 2024 13:52
@rlouf rlouf linked an issue Dec 9, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove JSON Schema Python tests
2 participants