Support URI format #129
Merged
Support URI format #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torymur
reviewed
Dec 19, 2024
torymur
reviewed
Dec 19, 2024
This reverts commit dc14a22.
torymur
reviewed
Dec 19, 2024
Closed
sky-2002
added a commit
to sky-2002/outlines-core
that referenced
this pull request
Dec 19, 2024
Adds URI parsing code and tests Refer dottxt-ai#127
sky-2002
added a commit
to sky-2002/outlines-core
that referenced
this pull request
Dec 19, 2024
Adds URI parsing code and tests Refer dottxt-ai#127
sky-2002
added a commit
to sky-2002/outlines-core
that referenced
this pull request
Dec 19, 2024
Adds URI parsing code and tests Refer dottxt-ai#127
sky-2002
added a commit
to sky-2002/outlines-core
that referenced
this pull request
Dec 19, 2024
Adds URI parsing code and tests Refer dottxt-ai#127
torymur
pushed a commit
to sky-2002/outlines-core
that referenced
this pull request
Dec 20, 2024
Adds URI parsing code and tests Refer dottxt-ai#127
torymur
pushed a commit
to sky-2002/outlines-core
that referenced
this pull request
Dec 20, 2024
Adds URI parsing code and tests Refer dottxt-ai#127
yvan-sraka
reviewed
Dec 20, 2024
| @@ -34,13 +34,15 @@ pub static DATE_TIME: &str = r#""(-?(?:[1-9][0-9]*)?[0-9]{4})-(1[0-2]|0[1-9])-(3 | |||
| pub static DATE: &str = r#""(?:\d{4})-(?:0[1-9]|1[0-2])-(?:0[1-9]|[1-2][0-9]|3[0-1])""#; | |||
| pub static TIME: &str = r#""(2[0-3]|[01][0-9]):([0-5][0-9]):([0-5][0-9])(\\.[0-9]+)?(Z)?""#; | |||
| pub static UUID: &str = r#""[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}""#; | |||
| pub static URI: &str = r#"^(https?|ftp):\/\/([^\s:@]+(:[^\s:@]*)?@)?([a-zA-Z\d.-]+\.[a-zA-Z]{2,}|localhost)(:\d+)?(\/[^\s?#]*)?(\?[^\s#]*)?(#[^\s]*)?$|^urn:[a-zA-Z\d][a-zA-Z\d\-]{0,31}:[^\s]+$"#; | |||
There was a problem hiding this comment.
I would be curious to see a pointer to the specifications where most of these regexes are defined, as I wouldn't be able to confirm later with my own eyeballs that they're 100% correct!
There was a problem hiding this comment.
@yvan-sraka I am also searching for specifications where regexes are defined (because same is the case with my eyeballs 👀 )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds URI parsing code and tests. Lmk if regex needs to cover other cases (regex credits chatgpt 😅 )
Closes #127
Note: Created separate PR than email format so that no blocking if update/refactor needed