Allow Parenthesis in STRING_INNER (#899)

Fix #838 06d5654 erroneously disallowed parenthesis in strings. This PR allows parenthesis in strings.
dottxt-ai · May 18, 2024 · 7863f8e · 7863f8e
1 parent 3e291b1
commit 7863f8e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/outlines/fsm/json_schema.py b/outlines/fsm/json_schema.py
@@ -10,7 +10,7 @@
 from referencing._core import Resolver
 from referencing.jsonschema import DRAFT202012
 
-STRING_INNER = r'([^("\\\x00-\x1f\x7f-\x9f)]|\\\\)'
+STRING_INNER = r'([^"\\\x00-\x1f\x7f-\x9f]|\\\\)'
 STRING = f'"{STRING_INNER}*"'
 INTEGER = r"(-)?(0|[1-9][0-9]*)"
 NUMBER = rf"({INTEGER})(\.[0-9]+)?([eE][+-][0-9]+)?"

diff --git a/tests/fsm/test_json_schema.py b/tests/fsm/test_json_schema.py
@@ -119,6 +119,8 @@ def test_match_number(pattern, does_match):
             STRING,
             [
                 ("unquotedstring", False),
+                ('"(parenthesized_string)"', True),
+                ('"malformed) parenthesis (((() string"', True),
                 ('"quoted_string"', True),
                 (r'"escape_\character"', False),
                 (r'"double_\\escape"', True),