-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vLLM requirement to be relaxed #989
Comments
I'm not sure how this can be accomplished without breaking vLLM tests in CI. Do you know of a good way to do this? Otherwise, I think you can just run We could also skip vLLM tests if the hardware is inappropriate like we do with mlxlm here https://github.com/outlines-dev/outlines/blob/main/tests/generate/conftest.py#L6 |
I can confirm this PR did solve my issue, and I was also able to run the pytest suite. Thank you :) |
What behavior of the library made you think about the improvement?
I am trying to contribute on mac, but I run into the following error when I am setting up my dev environment:
This makes it difficult for Mac and for non-WSL developers to contribute
How would you like it to behave?
To not complain about vLLM requirements not being met to support Mac or non-WSL Windows development
The text was updated successfully, but these errors were encountered: