Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pyproject.toml, enable mlx-lm requirement only on darwin, disable vllm requirement on darwin #1005

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

lapp0
Copy link
Collaborator

@lapp0 lapp0 commented Jun 25, 2024

Problem

pip install -e .[test] fails under two addressed conditions:

  • gnu/linux user attempts to install mlx-lm dependency
  • darwin user attempts to install vllm dependency.

Solution

Update pyproject.toml, ensure vllm and mlx-lm are installed only on appropriate systems.

@rlouf rlouf merged commit 8406f44 into dottxt-ai:main Jun 25, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vLLM requirement to be relaxed
2 participants