Version the Documentation #1059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lapp0
force-pushed
the
version-documentation
branch
from
22ea58d
to
efdb759
Compare
Merged
rlouf
pushed a commit
that referenced
this pull request
Aug 29, 2024
I updated some of the text of the modal example to add more information on what's happening where, since Modal's general structure may be unfamiliar to new users. List of changes: - Removed version constraints on the image. I think this is a questionable choice so I'd love input -- in general, this should probably better be addressed by versioning the docs #999. There's an open PR #1059 here that can help with this too -- I'm happy to revert to pinned versions, or at least update to the current version of outlines (0.0.46). - Added a brief note that the Mistral model is gated and requires you to request access on HuggingFace. - Moved the environment variable setting from `import_model` to a `.env` call when the image is created. This is more idiomatic Modal code. It was previously addressed in #1058, but this should be more current. - More comments and prep.
lapp0
force-pushed
the
version-documentation
branch
from
efdb759
to
64733a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #999
Changes
Versions the documentation using
mike.Demo:
Behavior:
/redirects to/stableSet Up
Must have https://github.com/outlines-dev/outlines/settings/pages set to "deploy from a branch" with branch of
gh-pagesMust cut a release after merging for the following reason:
After merging this PR:
After cutting a release