Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Broken pyairports Package, Replace with airportsdata #1156

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Remove Broken pyairports Package, Replace with airportsdata #1156

merged 1 commit into from
Sep 17, 2024

Conversation

lapp0
Copy link
Contributor

@lapp0 lapp0 commented Sep 16, 2024

Fixes #1093

pyairports is unmaintained and often breaks pip install outlines. It's also out of date.

This PR replaces it with the more recently maintained and working package airportsdata

@lapp0 lapp0 marked this pull request as ready for review September 16, 2024 19:08
@lapp0 lapp0 marked this pull request as draft September 16, 2024 19:09
@lapp0 lapp0 marked this pull request as ready for review September 16, 2024 20:11
cpfiffer
cpfiffer approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@cpfiffer cpfiffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm all for this one!

@rlouf rlouf merged commit 1894fa3 into dottxt-ai:main Sep 17, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpfiffer cpfiffer cpfiffer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove pyairports
3 participants
@lapp0 @cpfiffer @rlouf