-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add More Grammars to outlines.grammars
, Benchmark and Verify Their Integrity
#587
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlouf
added
enhancement
structured generation
Linked to structured generation
grammar
labels
Jan 26, 2024
…o extend current terminal vs transition to next
…ognized as being a different terminal
This was referenced Feb 7, 2024
…mark-cfg-generation
1 task
Closed
Closing due to inactivity. Feel free to re-open. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
outlines.grammars
and fixes some grammarsCFGFSM
(pytest --benchmark-cfg
)UnexpectedToken
error resulting from a partially complete terminal being lexed as a full terminal (seefsm.py
)There are a lot of files changed in this PR, but they're mostly new lark grammars, lark grammar improvements, and many sample test files.
outlines/grammars.py
with new grammarsfsm.py
outlines.grammars
outlines/tests/benchmark/cfg_samples/
Fixes:
ESCAPED_STRING
incommon.lark
and documents lookaround behavior)arithmetic.lark
to not result in deep recursion)Prerequisites
outlines.grammars
)Create / Fix Grammars
outlines.grammars.csv
ESCAPED_STRING
inoutlines.grammars.json
outlines.grammars.lark
outlines.grammars.sql_select
(maybe reach out to https://motherduck.com/blog/duckdb-text2sql-llm/)outlines.grammars.lisp
outlines.grammars.arithmetic
recursion issueOther Work
CFGFSM.regex_fsm
is constructed inoutlines/fsm/fsm.py
ESCAPED_STRING
incommon.lark
so it's compatible with interegularfoo.py.test
so it doesn't confuse users searching the repooutlines.grammars.arithmetic
Documentation Work
[ ] Documentation and examples of grammars in useCFGFSM
be LALR(1) per MakeCFGFSM
LALR(1) #588 before showing userssql_select
Out of scope because they require the introduction of context-sensitive indentation handling #592
outlines.grammars.python3
(andoutlines.grammars.python3_interactive
)outlines.grammars.yaml
Out of scope otherwise
outlines.grammars.bash
Questions:
pytest
is run, and run all of them whenpytest --do-benchmark
is run. Running a single test will help ensure the changeset doesn't break CFG in general, without the need to test all grammars.Output
Profile