-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerize and Add Release-Push Workflow #688
Conversation
temporarily remove pypi step fix spacing in runner include necessary docker components remove default model add docker build to contribute guide include . in context try v2 try immediately after checkout try this BUILDKIT_CONTEXT_KEEP_GIT_DIR try version downgrade try this try this try this include pypi
Thanks! Let's add a section in the docs' serve page, and maybe on the README as well? |
Great idea. Added to the docs with |
The repository: https://hub.docker.com/repository/docker/outlinesdev/outlines/general. Secrets should be properly configured in the new "release" environment. |
This looks good to me. Is it ready on your end? |
a6cba64
to
e2d2308
Compare
@rlouf Build was successful on https://github.com/lapp0/outlines and the resulting docker container worked for me. Docs seem fine. Only question is whether it'll work with this repos configuration We either can either release a new version to check if it works with your GitHub configuration, or I can add a |
Good idea for the dispatch! It can be a real pain to debug workflows, even more if we need to cut a new release every time there's a failure. |
e2d2308
to
834e700
Compare
Thanks! It would be less error-prone to have two separate |
https://github.com/outlines-dev/outlines/actions/workflows/release.yml will have a "Run Workflow" button once this is in Example run via
True |
f463b17
to
a554988
Compare
Oops, looks like you already implemented. Please push yours once more. |
We did the same thing. Let's merge and see |
@rlouf My push was missing a checkout step, I don't expect it to pass for pypi. Edit: the current failure is due to it missing 036693b#diff-87db21a973eed4fef5f32b267aa60fcee5cbdf03c67fafdc2a9b553bb0b15f34R35 Sorry, I should have been more clear that my push wasn't ready and marked as draft. |
Fixes #555
outlines.serve.serve
.release.yml
Need some setup on your end please @rlouf:
release.yml
and docsDOCKERHUB_USERNAME
andDOCKERHUB_TOKEN
secrets on GitHub in an environment named "release".TODO: