[Draft] Add option to ignore fields order #733
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leloykun
changed the title
|
Thank you! My worry with this technique is that it will make the regexes much longer and therefore increase compilation time for all schemas. Would you mind taking a couple examples and giving the length of the resulting regexes with and without your change? |
|
Closing this as I have a better idea in mind |
|
@leloykun Would you mind telling me your idea? I have a problem with ordering. Can I somehow make it like in the schema? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Predibase recently published an article wherein they discussed an issue with the fact that Outlines imposes an ordering constraint on object fields. See below:
This PR just adds an option to turn this constraint off. This does not change the default API interface at all.
There are probably a lot of smarter ways to do this, but this is good enough of a hack.
TODOs: