Added generate.probabilities for BeamSearch
#895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonwillard
changed the title
generate.probabilities for `BeamSearch
LouisHernandez17
force-pushed
the
probabilities
branch
from
0ac63f1
to
3493539
Compare
LouisHernandez17
force-pushed
the
probabilities
branch
from
f6cedd6
to
4f0766b
Compare
rlouf
changed the title
generate.probabilities for `BeamSearchgenerate.probabilities for BeamSearch
lapp0
reviewed
Jun 25, 2024
There was a problem hiding this comment.
Great contribution!
We'll likely be moving models.transformers to SequenceGeneratorAdapter in #966 once there is a new transformers release (along with models.llamacpp, models.mamba, and models.vllm).
IMO we should hold off on this PR until we've moved transformers to SequenceGeneratorAdapter so we can ensure the changes continue to work.
| model = models.transformers("mistralai/Mistral-7B-v0.1") | ||
| probabilities = generate.probabilities(model, ["skirt", "dress", "pen", "jacket"]) | ||
| answer = probabilities("Pick the odd word out: skirt, dress, pen, jacket") | ||
| print(answer) |
There was a problem hiding this comment.
Can we please see the answer printed?
| assert isinstance( | ||
| sampler, BeamSearchSampler | ||
| ), "Only BeamSearchSampler is supported for probabilities" | ||
| generator = regex(model, regex_str, sampler) |
There was a problem hiding this comment.
This returns a SequenceGeneratorAdapter in some cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the
sequence_weightsreturned by theBeamSearchsampler to augment the results with associated probabilities, as discussed in #479.