Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix os.environ use in docs #990

Closed
wants to merge 2 commits into from
Closed

Fix os.environ use in docs #990

wants to merge 2 commits into from

Conversation

rshah713
Copy link
Contributor

No description provided.

lapp0
lapp0 suggested changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@lapp0 lapp0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Could we have the load_dotenv portion in a separate code block labelled as optional?

@rlouf
Copy link
Member

rlouf commented Jun 20, 2024

Good catch!

+1

Could we have the load_dotenv portion in a separate code block labelled as optional?

Could we remove it instead? This adds confusion more than anything.

@rlouf rlouf mentioned this pull request Jun 20, 2024
Merged
@rlouf
Copy link
Member

rlouf commented Jun 20, 2024

Fixed in #993. Thank you for contributing!

@rlouf rlouf closed this Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lapp0 lapp0 lapp0 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rshah713 @rlouf @lapp0