Ensure models.llamacpp
Doesn't Have Implicit max_tokens
#996
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #973
Problem
In #973 an invalid pattern was being generated, however it was only invalid because it was incomplete. in the
LlamaCpp.generate()
callllama_cpp_params["max_tokens"]
was unset, however the model was still finishing for reason "length":In turns out the max tokens was being implicitly set to
30
.Solution
Allow 2**30 tokens if
max_length
is unset /None
, becausellama_cpp_params
requires anint
for themax_tokens
field.