Use outlines.processors
for models.llamacpp
#997
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #965
Problem
in
main
generate.fsm
only supportsSequenceGenerator
,models.llamacpp
doesn't supportSequenceGenerator
, it only supportsSequenceGeneratorAdapter
integrations.llamacpp
doesn't have a FSM logits processor.Solution
models.llamacpp
usesoutlines.processors
/SequenceGeneratorAdapter
for all generatorsgenerate.fsm
to useSequenceGeneratorAdapter
for all unified modelstest_generate.py
tests forgenerate.fsm
onMLXLM
,llamacpp
, andtransformers
(the three models usingoutlines.processors
)generate.fsm
bug discovered through this test inguide.py
impacting all models