Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README update from #125 #127

Merged
merged 4 commits into from
Jul 29, 2024
Merged

README update from #125 #127

merged 4 commits into from
Jul 29, 2024

Conversation

kentslaney
Copy link
Contributor

No description provided.

README.rst Outdated
available on travis.
libmc is developed and maintained by Douban Inc. Currently, it is
working in a production environment, powering all web traffic on
`douban.com <https://www.semrush.com/website/douban.com/overview/>`__. [#]_
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to link to https://douban.com .
If rank by semrush is considered useful, maybe putting it inside parentheses or moving to comment area would be better.

Copy link

@guibog guibog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kentslaney, thanks for the the useful edits in this PR. We think the semrush data is not really reliable for PRC based services, is there a better source for stats? If not, a direct link to douban.com or maybe a link to wikipedia's page could be ok too.

@kentslaney
Copy link
Contributor Author

How about this link instead? I wanted to link to site usage data rather than the home page since the volume of requests supported seems more relevant for libmc users than the content of the site.

@lexdene
Copy link
Contributor

lexdene commented Jun 11, 2024

I insist that https://douban.com would be better.
If an about page is preferred, how about https://douban.com/about?

I dont agree with https://jobs.douban.com/about/.
It is not relevant to a hiring jobs page.

I agree with site usage data,
but site usage data should not appear in a more primary position than https://douban.com.

@guibog
Copy link

guibog commented Jun 11, 2024

@kentslaney maybe two links can work better than a link on jobs page, like: powering all web traffic on _douban.com _ (_page on wikipedia in English_)

@kentslaney
Copy link
Contributor Author

Ok, I did a link to the main page and another to the english wiki. It was a little weird having a link with the text douban.com not going to the home page anyway.

@lexdene lexdene merged commit 9987819 into douban:master Jul 29, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants