Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix not_initialized error code #2234

Merged
merged 1 commit into from
Feb 3, 2024
Merged

Conversation

IjzerenHein
Copy link
Contributor

The error-code that is emitted when the player is not initialized is the same as when the player is already initialized (the error messages themselves are okay).

@IjzerenHein IjzerenHein requested a review from dcvz as a code owner January 5, 2024 12:42
@uzegonemad
Copy link

@dcvz @jspizziri Could we get this one merged?

Copy link
Collaborator

@jspizziri jspizziri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @puckey?

Copy link
Contributor

@dcvz dcvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 thanks for bringing this to par with Android

@dcvz dcvz merged commit f53fe01 into doublesymmetry:main Feb 3, 2024
3 checks passed
@IjzerenHein
Copy link
Contributor Author

Thanks for merging and this great library guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants