Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fix will only preserve links (hyperlinks and internal links) and nothing else. This is a limitation of the TeX packages we have available, both
pax
andnewpax
can only extract links and nothing else. The TeX engine can insert annotations with a package likepdfcomment
, but we cannot extract them from the PDFs we are including, so this is as good as it gets right now.Changes made
Update erb templates
app/views/layouts/application.pdf.erbtex
app/views/task/task_pdf.pdf.erb
app/views/portfolio/portfolio_pdf.pdf.erb
Update installation script to install
newpax
withtlmgr
Update installation script to patch the current version of
newpax
(calltlmgr info --only-installed --data cat-version newpax
and ensure we are only patching v0.52)Improve logging in
app/helpers/file_helper.rb
to report whether PDF compression has happened or notFixes: #130 and doubtfire-lms/doubtfire-web#337
Does not fix: #326
Tests done
CI run:
https://github.com/ublefo/doubtfire-api/runs/7643617478?check_suite_focus=true
Additional tests done locally:
file_helper
and made sure links are still present after processing.