Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Persistent pdf-viewer zoom level #876

Open
wants to merge 2 commits into
base: 8.0.x
Choose a base branch
from

Conversation

b0ink
Copy link

@b0ink b0ink commented Sep 28, 2024

Description

This change ensures that zoom levels in the pdf-viewer component persist across different PDFs and user submissions, instead of resetting to the default zoom every time.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Login as atutor or aconvenor and select the inbox/explorer tab to view a list of student submissions.
Select one of the submissions and modify the zoom level.
Select a different submission and/or refresh the page to verify that the zoom level remains the same.

Testing Checklist:

  • Tested in latest Chrome
  • Tested in latest Safari
  • Tested in latest Firefox

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link
Contributor

@maddernd maddernd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@macite this looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants