Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hibernate functionality #103

Merged
merged 6 commits into from
Jul 21, 2023
Merged

Conversation

padawarmik
Copy link
Contributor

Hi,
Following PR is adding the Hibernate (save to disk) functionality.
I have tested it on my local instance and it works fine.
If you have any suggestions please let me know!

@dougiteixeira dougiteixeira marked this pull request as draft July 20, 2023 05:02
Copy link
Owner

@dougiteixeira dougiteixeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you point out where this is documented to verify the implication across the various versions of Proxmox?

@padawarmik
Copy link
Contributor Author

padawarmik commented Jul 21, 2023

Sure, it's documented under the suspend option as "todisk":
https://pve.proxmox.com/pve-docs/api-viewer/index.html#/nodes/{node}/qemu/{vmid}/status/suspend

@dougiteixeira
Copy link
Owner

dougiteixeira commented Jul 21, 2023

Sure, it's documented under the suspend option as "todisk":
https://pve.proxmox.com/pve-docs/api-viewer/index.html#/nodes/{node}/qemu/{vmid}/status/suspend

Let's move on to add that.

Please can you update the branch to the latest version and add translation_key and entity name in strings.json and translations/en.json.

@padawarmik padawarmik marked this pull request as ready for review July 21, 2023 22:28
@padawarmik
Copy link
Contributor Author

Done. You can review the changes I have made.

@dougiteixeira dougiteixeira merged commit c6a6cdc into dougiteixeira:main Jul 21, 2023
1 check passed
@dougiteixeira
Copy link
Owner

Thanks @padawarmik!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants