Improved AndroidPlatformStrategy & Factory, to avoid memory leak of Context #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ontext... by storying reference to TextView (which is a subclass of View, which contains a reference to the Context) Now, Factory only takes in one Object, and AndroidPlatformStrategy uses method to 'reach' the TextView.
…and moved ServiceConnection creation to a Factory class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used to store reference to TextView (which is a subclass of View, which contains a reference to the Context)
This leads to a possible Memory Leak
Now, Factory only takes in one Object, and AndroidPlatformStrategy uses a method to 'reach' the TextView.
This 'method' based access of the TextView (defined in OutputTextViewActivity.java ) allows for non-memory-leaking of the Context.