Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added erfcinv #8

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Added erfcinv #8

wants to merge 3 commits into from

Conversation

peppelauro
Copy link

Add function erfcinv (Inverse Complementary Error Function)

Add function erfcinv (Inverse Complementary Error Function)
@dougthor42
Copy link
Owner

Wonderful, thanks! Overall it looks great - very clean. A couple in-line comments.

Please do the following:

  1. Add unit tests to pyerf/tests/test_pyerf.py for:
    1. known values (especially at the extremes)
    2. exceptions raised
    3. comparison to numpy/scipy results
  2. Remove trailing whitespace from lines.

You can ignore the failing build - that's pip 18 dropping support for Py3.3. I'll fix that in another MR.

pyerf/pyerf.py Outdated Show resolved Hide resolved
pyerf/pyerf.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants