DOV-7024: Improve dcrypt design documentation #1132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Consolidate external links, - create extra sub-headers for encryption/decryption sections, - simplify enumeration syntax to reduce error potentials, and - add dovecotlinks for internal sections.
- Shorten "ECC" to "EC" for the key type, - add key checksum to end of key-block, - add message integrity tag at end of message, and - fix alignment of byte offsets as well as descriptions.
This comment has been minimized.
This comment has been minimized.
cmouse
requested changes
Jan 15, 2025
fleischie
force-pushed
the
DOV-7024/rewrite-dcrypt-decrypt
branch
from
1e880ab to
db9eebc
Compare
cmouse
requested changes
Jan 16, 2025
fleischie
force-pushed
the
DOV-7024/rewrite-dcrypt-decrypt
branch
from
db9eebc to
7cd1733
Compare
This comment has been minimized.
This comment has been minimized.
fleischie
force-pushed
the
DOV-7024/rewrite-dcrypt-decrypt
branch
2 times, most recently
from
a7a49c1 to
bdbd979
Compare
fleischie
force-pushed
the
DOV-7024/rewrite-dcrypt-decrypt
branch
from
bdbd979 to
5cf453f
Compare
cmouse
previously approved these changes
Jan 16, 2025
This comment has been minimized.
This comment has been minimized.
fleischie
force-pushed
the
DOV-7024/rewrite-dcrypt-decrypt
branch
from
5cf453f to
c6d9bec
Compare
cmouse
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dcrypt-decrypt.pyscript. (Which depending on review might not yet be fully published.)Closes DOV-7024.