Fix PQ popping elements on insert when no size limit is specified (#1)

downflux · Aug 17, 2022 · c30826f · c30826f
1 parent 6724a78
commit c30826f
Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/pq/pq.go b/pq/pq.go
@@ -83,7 +83,7 @@ func (pq *PQ[T]) Push(p T, priority float64) {
 		p:      p,
 		weight: priority,
 	})
-	for !pq.Empty() && pq.Len() > pq.n {
+	for !pq.Empty() && pq.Len() > pq.n && pq.n > 0 {
 		pq.Pop()
 	}
 }

diff --git a/pq/pq_test.go b/pq/pq_test.go
@@ -47,15 +47,17 @@ func TestPQ(t *testing.T) {
 			},
 		},
 		{
-			name: "Trivial/NoSize",
+			name: "Trivial/NoSizeLimit",
 			data: []item{
 				{
 					p:        X{1},
 					priority: 0,
 				},
 			},
 			size: 0,
-			want: nil,
+			want: []X{
+				X{1},
+			},
 		},
 
 		{