Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Unable to geocode destination address to coordinates: Index 0 out of range [0..0) error (Android) #281 #282

Merged

Conversation

ryaa
Copy link
Contributor

@ryaa ryaa commented Nov 11, 2024

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation changes
  • Other... Please describe:

PR Checklist

For bug fixes / features, please check if your PR fulfills the following requirements:

  • Testing has been carried out for the changes have been added
  • Regression testing has been carried out for existing functionality
  • Docs have been added / updated

What is the purpose of this PR?

Correctly handle the geocoding returning no results and fix this issue #281

Does this PR introduce a breaking change?

  • Yes
  • No

What testing has been done on the changes in the PR?

Tested the fix in my local project.

What testing has been done on existing functionality?

Tested the fix in my local project.

Other information

For more details please see #281

@ryaa
Copy link
Contributor Author

ryaa commented Nov 11, 2024

Sorry. I had to fix the minor typo in the original PR - see #283

@dpa99c
Copy link
Owner

dpa99c commented Nov 11, 2024

no worries, it's merged

@ryaa
Copy link
Contributor Author

ryaa commented Dec 3, 2024

@dpa99c any plans to release new version with the above fix?

@dpa99c
Copy link
Owner

dpa99c commented Dec 3, 2024

Sorry, thought I had released it. I'll publish it in a patch version now.

@dpa99c
Copy link
Owner

dpa99c commented Dec 3, 2024

published as [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants