Update settings.php for data_pipelines url #271
Conversation
| $elasticsearch_url = (getenv('SEARCH_HASH') && getenv('SEARCH_URL')) ? sprintf('http://%s.%s', getenv('SEARCH_HASH'), getenv('SEARCH_URL')) : "http://elasticsearch:9200"; | ||
| $data_pipeline_configs = [ | ||
| 'sdp_elasticsearch', | ||
| 'sdp_elasticsearch_v1', |
There was a problem hiding this comment.
I meant to ask in the other PR.... what's v1 for?
There was a problem hiding this comment.
v1 represents version 1 😜
sdp_elasticsearch_v1 indicates it uses the Destination plugin that defined by tide_data_pipeline module.
There was a problem hiding this comment.
We've had to override the existing plugin to get new functionality?
There was a problem hiding this comment.
We've had to override the existing plugin to get new functionality?
it is the content thing, we can't override it, we have to select it via datapipeline content e.g. https://develop.content.vic.gov.au/admin/content/datasets/manage/3/edit?destination=/admin/content/datasets
The plan of mine is for these 2 types of Destinations to coexist for now. If it is a new data pipeline or needs to be switched to v1, we only need to select v1 in the datapipeline content
There was a problem hiding this comment.
I don't have enough context to approve this PR. @anthony-malkoun are you happy with Vincent's justification?
Checklist
Explain the details for making this change. What existing problem does the pull request solve?
Changelog Entry
This PR relates to
multi_value_processorplugin to thetide_data_pipelinemodule to handle multiple values. tide_search#85the
sdp_elasticsearch_v1destination will be available for other projects.sdp_elasticsearch_v1supports- dpc-sdp/tide_search#85
- and (maybe) more new features that only available on SDP
We don't want to remove the sdp_elasticsearch destination for now