Merge pull request #1115 from dpc-sdp/feature/fix-api-exports

fix undefined process error in client side code
dpc-sdp · Apr 18, 2024 · 919e6ad · 919e6ad
2 parents 5c9248f + 20033df
commit 919e6ad
Show file tree

Hide file tree

Showing 13 changed files with 22 additions and 11 deletions.
diff --git a/examples/nuxt-app/components/global/VsbaMapPopupContent.vue b/examples/nuxt-app/components/global/VsbaMapPopupContent.vue
@@ -25,7 +25,7 @@
 </template>
 
 <script setup lang="ts">
-import { stripSiteId } from '@dpc-sdp/ripple-tide-api'
+import { stripSiteId } from '@dpc-sdp/ripple-tide-api/helpers'
 
 interface Props {
   feature: any

diff --git a/examples/nuxt-app/mock-routes.json b/examples/nuxt-app/mock-routes.json
@@ -25,7 +25,7 @@
   },
   {
     "path": "/publication-page",
-    "fixture": "publication-page/sample-publication-page.json"
+    "fixture": "publication/sample-publication-page.json"
   },
   {
     "path": "/",

diff --git a/examples/nuxt-app/package.json b/examples/nuxt-app/package.json
@@ -24,6 +24,7 @@
   "dependencies": {
     "@dpc-sdp/nuxt-ripple": "workspace:*",
     "@dpc-sdp/nuxt-ripple-analytics": "workspace:*",
+    "@dpc-sdp/nuxt-ripple-cli": "workspace:*",
     "@dpc-sdp/nuxt-ripple-preview": "workspace:*",
     "@dpc-sdp/ripple-tide-event": "workspace:*",
     "@dpc-sdp/ripple-tide-topic": "workspace:*",

diff --git a/packages/nuxt-ripple-cli/src/commands/favicon/index.ts b/packages/nuxt-ripple-cli/src/commands/favicon/index.ts
@@ -17,7 +17,6 @@ export default function rplFaviconCommand() {
       'Absolute path to public directory',
       `${process.cwd()}/public`
     )
-    .parse(process.argv)
     .action(() => favicon(rplFaviconCommand.opts()))
 
   return rplFaviconCommand

diff --git a/packages/nuxt-ripple/utils/breadcrumbs.ts b/packages/nuxt-ripple/utils/breadcrumbs.ts
@@ -1,4 +1,4 @@
-import { stripSiteId } from '@dpc-sdp/ripple-tide-api'
+import { stripSiteId } from '@dpc-sdp/ripple-tide-api/helpers'
 
 // Private helpers
 function getActivePath(branch, path) {

diff --git a/packages/ripple-tide-api/package.json b/packages/ripple-tide-api/package.json
@@ -12,6 +12,7 @@
   "exports": {
     ".": "./dist/index.js",
     "./utils": "./dist/utils.js",
+    "./helpers": "./dist/helpers.js",
     "./types": "./types.d.ts",
     "./errors": "./dist/errors/errors.js",
     "./components": "./dist/nuxt/components",

diff --git a/packages/ripple-tide-api/src/helpers.ts b/packages/ripple-tide-api/src/helpers.ts
@@ -0,0 +1,6 @@
+export * from './utils/mapping-utils.js'
+export { stripSiteId } from './utils/stripSiteId.js'
+export {
+  addAnchorLinksToHTML,
+  getAnchorLinksFromHTML
+} from './utils/anchorLinks.js'
diff --git a/packages/ripple-tide-landing-page/components/global/TideLandingPage/ContentCollection.vue b/packages/ripple-tide-landing-page/components/global/TideLandingPage/ContentCollection.vue
@@ -55,7 +55,7 @@ import {
   IContentCollectionSort
 } from '../../../mapping/components/content-collection/content-collection-mapping'
 import type { IRplFeatureFlags } from '@dpc-sdp/ripple-tide-api/types'
-import { stripSiteId } from '@dpc-sdp/ripple-tide-api'
+import { stripSiteId } from '@dpc-sdp/ripple-tide-api/helpers'
 
 const { public: config } = useRuntimeConfig()
 

diff --git a/packages/ripple-tide-search/components/TideSearchPage.vue b/packages/ripple-tide-search/components/TideSearchPage.vue
@@ -10,7 +10,7 @@ import { FormKit } from '@formkit/vue'
 import { SearchDriverOptions } from '@elastic/search-ui'
 import { useRippleEvent } from '@dpc-sdp/ripple-ui-core'
 import type { rplEventPayload } from '@dpc-sdp/ripple-ui-core'
-import { stripSiteId } from '@dpc-sdp/ripple-tide-api'
+import { stripSiteId } from '@dpc-sdp/ripple-tide-api/helpers'
 
 interface Props {
   id: string

diff --git a/packages/ripple-tide-search/composables/useSearchResult.ts b/packages/ripple-tide-search/composables/useSearchResult.ts
@@ -1,6 +1,6 @@
 import { computed } from 'vue'
 import { getSearchResultValue, truncateText } from '#imports'
-import { stripSiteId } from '@dpc-sdp/ripple-tide-api'
+import { stripSiteId } from '@dpc-sdp/ripple-tide-api/helpers'
 
 interface ResultOptions {
   summaryMaxLength: number | null

diff --git a/packages/ripple-tide-search/pages/search.vue b/packages/ripple-tide-search/pages/search.vue
@@ -1,5 +1,5 @@
 <script setup lang="ts">
-import { stripSiteId } from '@dpc-sdp/ripple-tide-api'
+import { stripSiteId } from '@dpc-sdp/ripple-tide-api/helpers'
 import { AppSearchFilterConfigItem, MappedSearchResult } from '../types'
 import { formatDate, useRuntimeConfig, useAppConfig } from '#imports'
 

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/tsconfig.json b/tsconfig.json
@@ -22,6 +22,7 @@
     ],
     "paths": {
       "@dpc-sdp/ripple-tide-api/errors": ["ripple-tide-api/src/errors/errors"],
+      "@dpc-sdp/ripple-tide-api/helpers": ["ripple-tide-api/src/helpers"],
       "@dpc-sdp/ripple-tide-api": ["ripple-tide-api/src"],
       "@dpc-sdp/ripple-ui-core": ["ripple-ui-core/src"],
       "@dpc-sdp/ripple-tide-event": ["ripple-tide-event/src"],