Skip to content

Commit

Permalink
Merge pull request #872 from dpc-sdp/fix/gha-lint-issues
Browse files Browse the repository at this point in the history
test: ✅ fix linter issues
  • Loading branch information
waitingallday authored Oct 1, 2023
2 parents ae9efa7 + 3042045 commit ab73e65
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 4 deletions.
2 changes: 1 addition & 1 deletion examples/nuxt-app/test/support/step_definitions/index.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import '@dpc-sdp/ripple-test-utils/step_definitions'
Cypress.on('uncaught:exception', (err, runnable) => {
Cypress.on('uncaught:exception', (err) => {
// https://stackoverflow.com/a/50387233
// Ignore Resize observer loop issue in expand search filters for now
if (err.message.includes('ResizeObserver loop')) {
Expand Down
1 change: 1 addition & 0 deletions packages/eslint-config-ripple/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ module.exports = {
'vue/max-attributes-per-line': 'off',
'vue/multi-word-component-names': 'off',
'vue/no-v-html': 'off',
'vue/v-on-event-hyphenation': 'off',
'@typescript-eslint/ban-ts-comment': 'off',
'@typescript-eslint/no-explicit-any': 'off', // allow explicit any types for now
'@typescript-eslint/no-unused-vars': [
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Then, When, DataTable } from '@badeball/cypress-cucumber-preprocessor'
import { Then } from '@badeball/cypress-cucumber-preprocessor'

Then(`the custom collection component should have a search input bar`, () => {
cy.get(`[data-component-type="TideCustomCollection"]`).find('.rpl-search-bar')
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export const dataTableMapping = (

const items = Object.keys(entries)
.filter((entryKey) => entryKey !== 'caption')
.filter((entryKey, i) => {
.filter((entryKey) => {
if (field?.field_first_row_table_header) {
// Exclude first row if it is a header
return entryKey !== '0'
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<script setup lang="ts">
import { getActiveFilterURL, useRoute, ref, toRaw } from '#imports'
import { getActiveFilterURL, ref } from '#imports'
import { submitForm } from '@formkit/vue'
import useTideSearch from './../../composables/useTideSearch'
import type {
Expand Down Expand Up @@ -145,6 +145,7 @@ const baseEvent = () => ({
})
// Updates filter options with aggregation value
// eslint-disable-next-line @typescript-eslint/no-unused-vars
onAggregationUpdateHook.value = (aggs) => {}
const emitSearchEvent = (event) => {
Expand Down

0 comments on commit ab73e65

Please sign in to comment.