refactor: ♻️ replace icon at mapping level

dpc-sdp · Oct 16, 2023 · b2eb2fd · b2eb2fd
1 parent 76d3233
commit b2eb2fd
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 13 deletions.
diff --git a/packages/nuxt-ripple/composables/use-tide-site.ts b/packages/nuxt-ripple/composables/use-tide-site.ts
@@ -32,17 +32,7 @@ export const useTideSite = async (id?: number): Promise<TideSiteData> => {
     return data.value
   }
 
-  // Intercept social links, replace icon-twitter with icon-x
-  return Object.fromEntries(
-    Object.entries(siteData.value).map(([k, v]) => [
-      k,
-      k !== 'socialLinks'
-        ? v
-        : siteData.value[k].map((link: any) =>
-            link.icon === 'icon-twitter' ? { ...link, icon: 'icon-x' } : link
-          )
-    ])
-  ) as any
+  return siteData.value
 }
 
 export default useTideSite
diff --git a/packages/nuxt-ripple/mapping/utils/processSiteSocialLinks.ts b/packages/nuxt-ripple/mapping/utils/processSiteSocialLinks.ts
@@ -23,7 +23,8 @@ export const getIconForUrl = (urlString: string) => {
     case 'linkedin.com':
       return 'icon-linkedin'
     case 'twitter.com':
-      return 'icon-twitter'
+    case 'x.com':
+      return 'icon-x'
     case 'youtube.com':
       return 'icon-youtube'
     default:

diff --git a/packages/ripple-ui-core/src/components/contact-us/RplContactUs.vue b/packages/ripple-ui-core/src/components/contact-us/RplContactUs.vue
@@ -42,7 +42,7 @@ const handleClick = (event) => {
   )
 }
 
-// Intercept social links to replace icon-twitter with icon-x
+// Replace icon-twitter with icon-x
 const socialLinks = computed(() =>
   props.items.map((i) =>
     i.icon === 'icon-twitter' ? { ...i, icon: 'icon-x' } : i