Adds script for fetching locality data from VicMap API #1059
+161,721
−155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ripple-docs canceled.
|
Passing run #1603 ↗︎
Details:
Review all test suite changes for PR #1059 ↗︎ |
|||||||||||||||
dylankelly
force-pushed
the
feature/vicmap-locality-script
branch
from
5d59f30 to
c7c696d
Compare
…y data from VicMap
…pport budget data
… data feat(@dpc-sdp/nuxt-ripple-cli): ✨ add CLI script for fetching locality data from VicMap refactor(@dpc-sdp/ripple-tide-api): ♻️ refactor locality script to support budget data feat(@dpc-sdp/nuxt-ripple-cli): 🚧 wip on budget data script fix(@dpc-sdp/nuxt-ripple-cli): 🐛 fix for budget data discrepencies, add tests fix(@dpc-sdp/nuxt-ripple-cli): 🐛 add fixes for problematic locality data fix(@dpc-sdp/nuxt-ripple-cli): 🐛 fix lint
dylankelly
force-pushed
the
feature/vicmap-locality-script
branch
from
021e565 to
f0516f4
Compare
waitingallday
approved these changes
Apr 23, 2024
jeffdowdle
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
What I did
How to test
pnpm -F @dpc-sdp/nuxt-ripple-cli nuxt-ripple localities--whereoption for testing with specific localities. EG:--where "LOCALITY_NAME in ('BONEGILLA', 'ABBEYARD')"Checklist
For all PR's
For new components only