Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(@dpc-sdp/ripple-sdp-core): ✨ combine tide layers into sdp-core #1165

Closed
wants to merge 6 commits into from
Closed

feat(@dpc-sdp/ripple-sdp-core): ✨ combine tide layers into sdp-core #1165

wants to merge 6 commits into from

Conversation

waitingallday
Copy link
Member

Issue:

What I did

  • Introduces @dpc-sdp/ripple-sdp-core as a single entry point to contain all Tide content type layers
  • Started migrating safe Tide-specific components from nuxt-ripple over to ripple-sdp-core
  • Updated some templates

How to test

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@waitingallday waitingallday self-assigned this May 15, 2024
@netlify Netlify
Copy link

netlify bot commented May 15, 2024 •
edited
Loading

✅ Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 1c837be
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/6699ffb72e106e00088e43ea

@waitingallday waitingallday mentioned this pull request May 15, 2024
Closed
6 tasks
@cypress Cypress
Copy link

cypress bot commented May 15, 2024 •
edited
Loading

Passing run #2083 ↗︎

0 179 0 0 Flakiness 0

Details:

Merge branch 'develop' into feat/sdp-core
Project: ripple-framework Commit: 1c837be4e4
Status: Passed Duration: 08:02 💡
Started: Jul 19, 2024 5:57 AM Ended: Jul 19, 2024 6:05 AM

Review all test suite changes for PR #1165 ↗︎

@waitingallday waitingallday marked this pull request as draft May 19, 2024 23:56
@waitingallday waitingallday marked this pull request as ready for review June 26, 2024 05:59
@waitingallday
Copy link
Member Author

Closed for #1273

@waitingallday waitingallday deleted the feat/sdp-core branch September 4, 2024 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lambry lambry Awaiting requested review from lambry

@dylankelly dylankelly Awaiting requested review from dylankelly

@jeffdowdle jeffdowdle Awaiting requested review from jeffdowdle

Assignees

@waitingallday waitingallday

Labels
DO NOT MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@waitingallday @dylankelly