Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SD-252] Back to top event #1328

Merged
merged 1 commit into from
Sep 24, 2024
Merged

[SD-252] Back to top event #1328

merged 1 commit into from
Sep 24, 2024

Conversation

lambry
Copy link
Contributor

@lambry lambry commented Sep 16, 2024

Issue: https://digital-vic.atlassian.net/browse/SD-252

What I did

  • Adds back to top event

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@lambry lambry self-assigned this Sep 16, 2024
@lambry lambry changed the base branch from develop to release/2.17.0 September 16, 2024 07:17
@netlify Netlify
Copy link

netlify bot commented Sep 16, 2024 •
edited
Loading

✅ Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit e9a6148
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/66e7db88a01c990008cfe051

@lambry lambry added this to the 2.17.0 milestone Sep 16, 2024
@dylankelly dylankelly merged commit f9760a1 into release/2.17.0 Sep 24, 2024
17 of 18 checks passed
@dylankelly dylankelly deleted the feature/back-to-top-event branch September 24, 2024 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffdowdle jeffdowdle jeffdowdle approved these changes

@dylankelly dylankelly dylankelly approved these changes

@waitingallday waitingallday waitingallday approved these changes

Assignees

@lambry lambry

Labels
None yet
Projects
None yet
Milestone
2.17.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lambry @waitingallday @dylankelly @jeffdowdle