Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SD-314] Breadcrumbs enhancement #1329

Merged
merged 4 commits into from
Sep 25, 2024
Merged

[SD-314] Breadcrumbs enhancement #1329

merged 4 commits into from
Sep 25, 2024

Conversation

waitingallday
Copy link
Member

Issue: https://digital-vic.atlassian.net/browse/SD-314

What I did

  • Team navigation proof of concept from sprint break

How to test

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed.
  • I've updated the documentation site as needed.
  • I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

  • I have added a story covering all variants
  • I have checked a11y tab in storybook passes
  • Any events are emitted on the event bus

@waitingallday waitingallday added this to the 2.17.0 milestone Sep 17, 2024
@waitingallday waitingallday self-assigned this Sep 17, 2024
@cypress Cypress
Copy link

cypress bot commented Sep 17, 2024 •
edited
Loading

ripple-framework    Run #2256

Run Properties:  status check failed Failed #2256  •  git commit 14f31aa0db: refactor(@dpc-sdp/ripple-ui-core): :recycle: use prop and featureflag
Project ripple-framework
Branch Review feat/breadcrumbs-update
Run status status check failed Failed #2256
Run duration 09m 36s
Commit git commit 14f31aa0db: refactor(@dpc-sdp/ripple-ui-core): :recycle: use prop and featureflag
Committer Jason Smith
View all properties for this run ↗︎
Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 195
View all changes introduced in this branch ↗︎

Tests for review

Failed  test/features/maps/maps.feature • 1 failed test

View Output

Test Artifacts
Custom collection map component > Popup - 'sidebar' type Test Replay Screenshots

dylankelly
dylankelly requested changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@dylankelly dylankelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CAn we put all of this behind a feature flag pls?

packages/ripple-ui-core/src/components/breadcrumbs/RplBreadcrumbs.vue Outdated Show resolved Hide resolved
@waitingallday waitingallday merged commit 3d775ce into release/2.17.0 Sep 25, 2024
11 of 14 checks passed
@waitingallday waitingallday deleted the feat/breadcrumbs-update branch September 25, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffdowdle jeffdowdle jeffdowdle approved these changes

@dylankelly dylankelly dylankelly approved these changes

@lambry lambry lambry approved these changes

Assignees

@waitingallday waitingallday

Labels
None yet
Projects
None yet
Milestone
2.17.0
Development

Successfully merging this pull request may close these issues.
4 participants
@waitingallday @lambry @dylankelly @jeffdowdle