Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release/2.17.4 #1367

Closed
wants to merge 5 commits into from
Closed

Release/2.17.4 #1367

wants to merge 5 commits into from

Conversation

dylankelly
Copy link
Contributor

Issue:

What I did

How to test

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed
  • I've updated the documentation site as needed
  • I have added tests to cover my changes (if not applicable, please state why in a comment)

For new UI components only

  • I have added a storybook story covering all variants
  • I have checked a11y tab in storybook passes
  • I have added cypress component tests (if the component is interactive)
  • Any events are emitted on the event bus using emitRplEvent

@netlify Netlify
Copy link

netlify bot commented Nov 7, 2024 •
edited
Loading

✅ Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit e7d1eda
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/672c2bce31c9a400080f5269

@dylankelly dylankelly changed the base branch from develop to release/2.17.3 November 7, 2024 02:54
@dylankelly dylankelly changed the base branch from release/2.17.3 to develop November 7, 2024 02:59
@dylankelly dylankelly changed the base branch from develop to release/2.17.3 November 7, 2024 03:04
@cypress Cypress
Copy link

cypress bot commented Nov 7, 2024 •
edited
Loading

ripple-framework    Run #2350

Run Properties:  status check passed Passed #2350  •  git commit d2ed03a278: update publish step
Project ripple-framework
Branch Review 2.17.4
Run status status check passed Passed #2350
Run duration 08m 54s
Commit git commit d2ed03a278: update publish step
Committer dylankelly
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 201
View all changes introduced in this branch ↗︎

@dylankelly dylankelly changed the base branch from release/2.17.3 to develop November 7, 2024 03:06
@dylankelly dylankelly changed the base branch from develop to release/2.17.3 November 7, 2024 03:35
@dylankelly dylankelly closed this Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lambry lambry lambry approved these changes

@jeffdowdle jeffdowdle Awaiting requested review from jeffdowdle

@waitingallday waitingallday Awaiting requested review from waitingallday

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dylankelly @lambry @jeffdowdle @waitingallday @sdpdeploy