Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(@dpc-sdp/nuxt-ripple-cli): 🔥 remove favicon generator #1382

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

waitingallday
Copy link
Member

Issue:

What I did

How to test

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed
  • I've updated the documentation site as needed
  • I have added tests to cover my changes (if not applicable, please state why in a comment)

For new UI components only

  • I have added a storybook story covering all variants
  • I have checked a11y tab in storybook passes
  • I have added cypress component tests (if the component is interactive)
  • Any events are emitted on the event bus using emitRplEvent

@waitingallday waitingallday added this to the 2.21.0 milestone Nov 14, 2024
@waitingallday waitingallday self-assigned this Nov 14, 2024
Copy link

cypress bot commented Nov 14, 2024

ripple-framework    Run #2379

Run Properties:  status check passed Passed #2379  •  git commit f1753d0951: refactor(@dpc-sdp/nuxt-ripple-cli): :fire: remove favicon generator
Project ripple-framework
Branch Review task/remove-favicon-generator
Run status status check passed Passed #2379
Run duration 09m 10s
Commit git commit f1753d0951: refactor(@dpc-sdp/nuxt-ripple-cli): :fire: remove favicon generator
Committer Jason Smith
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 211
View all changes introduced in this branch ↗︎

@waitingallday waitingallday merged commit 30f4610 into release/2.21.0 Nov 18, 2024
15 checks passed
@waitingallday waitingallday deleted the task/remove-favicon-generator branch November 18, 2024 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants