Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SD-403] Decoupled map search banner #1388

Merged

Conversation

jeffdowdle
Copy link
Contributor

@jeffdowdle jeffdowdle commented Nov 25, 2024

Issue: https://digital-vic.atlassian.net/browse/SD-403

What we did

  • Adds RplSearchBanner UI component in ripple-ui-core
  • Refactors Tidesearchaddresslookup component so that it can be used both within a map and standalone
  • Adds TideLandingPageMapSearchBanner to add to landing pages, which can be given similar props as TideSearchAddressLookup so that it functions the same as the corresponding map

How to test

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed
  • I've updated the documentation site as needed
  • I have added tests to cover my changes (if not applicable, please state why in a comment)

For new UI components only

  • I have added a storybook story covering all variants
  • I have checked a11y tab in storybook passes
  • I have added cypress component tests (if the component is interactive)
  • Any events are emitted on the event bus using emitRplEvent

@dylankelly
Copy link
Contributor

dylankelly commented Dec 5, 2024

FYI this will need to go into 2.23.0

@dylankelly dylankelly added this to the 2.22.0 milestone Dec 5, 2024
@dylankelly dylankelly changed the base branch from release/2.21.0 to release/2.22.0 December 5, 2024 22:37
Copy link

cypress bot commented Dec 5, 2024

ripple-framework    Run #2475

Run Properties:  status check passed Passed #2475  •  git commit 339a312fb2: test(@dpc-sdp/ripple-tide-search): added tests for map search banner
Project ripple-framework
Branch Review feature/SD-403-decoupled-map-search-stretch-image
Run status status check passed Passed #2475
Run duration 10m 30s
Commit git commit 339a312fb2: test(@dpc-sdp/ripple-tide-search): added tests for map search banner
Committer Jeffrey Dowdle
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 218
View all changes introduced in this branch ↗︎

@dylankelly dylankelly removed this from the 2.22.0 milestone Dec 6, 2024
Base automatically changed from release/2.22.0 to develop December 9, 2024 01:14
@jeffdowdle jeffdowdle changed the base branch from develop to release/2.23.0 December 9, 2024 04:30
…amework into feature/SD-403-decoupled-map-search-stretch-image

# Conflicts:
#	packages/ripple-tide-search/components/global/TideSearchAddressLookup.vue
@jeffdowdle jeffdowdle marked this pull request as ready for review December 9, 2024 04:46
@dylankelly dylankelly added this to the 2.23.0 milestone Dec 9, 2024
@jeffdowdle jeffdowdle marked this pull request as draft December 16, 2024 22:07
@jeffdowdle jeffdowdle marked this pull request as ready for review December 17, 2024 02:54
@dylankelly dylankelly merged commit 1cdae25 into release/2.23.0 Dec 19, 2024
6 checks passed
@dylankelly dylankelly deleted the feature/SD-403-decoupled-map-search-stretch-image branch December 19, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants