-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SD-403] Decoupled map search banner #1388
Merged
dylankelly
merged 8 commits into
release/2.23.0
from
feature/SD-403-decoupled-map-search-stretch-image
Dec 19, 2024
Merged
[SD-403] Decoupled map search banner #1388
dylankelly
merged 8 commits into
release/2.23.0
from
feature/SD-403-decoupled-map-search-stretch-image
Dec 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 25, 2024
FYI this will need to go into 2.23.0 |
ripple-framework Run #2475
Run Properties:
|
Project |
ripple-framework
|
Branch Review |
feature/SD-403-decoupled-map-search-stretch-image
|
Run status |
Passed #2475
|
Run duration | 10m 30s |
Commit |
339a312fb2: test(@dpc-sdp/ripple-tide-search): added tests for map search banner
|
Committer | Jeffrey Dowdle |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
1
|
Pending |
0
|
Skipped |
0
|
Passing |
218
|
View all changes introduced in this branch ↗︎ |
…amework into feature/SD-403-decoupled-map-search-stretch-image # Conflicts: # packages/ripple-tide-search/components/global/TideSearchAddressLookup.vue
waitingallday
approved these changes
Dec 19, 2024
dylankelly
approved these changes
Dec 19, 2024
lambry
approved these changes
Dec 19, 2024
dylankelly
deleted the
feature/SD-403-decoupled-map-search-stretch-image
branch
December 19, 2024 22:42
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://digital-vic.atlassian.net/browse/SD-403
What we did
How to test
Checklist
For all PR's
For new UI components only
emitRplEvent