Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SD-423] New breadcrumbs style feedback #1396

Merged
merged 1 commit into from
Dec 5, 2024
Merged

[SD-423] New breadcrumbs style feedback #1396

merged 1 commit into from
Dec 5, 2024

Conversation

waitingallday
Copy link
Member

Issue: https://digital-vic.atlassian.net/browse/SD-423

What I did

  • Update styles

How to test

  • Storybook

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed
  • I've updated the documentation site as needed
  • I have added tests to cover my changes (if not applicable, please state why in a comment)

For new UI components only

  • I have added a storybook story covering all variants
  • I have checked a11y tab in storybook passes
  • I have added cypress component tests (if the component is interactive)
  • Any events are emitted on the event bus using emitRplEvent

@waitingallday waitingallday self-assigned this Dec 5, 2024
@cypress Cypress
Copy link

cypress bot commented Dec 5, 2024

ripple-framework    Run #2426

Run Properties:  status check passed Passed #2426  •  git commit e552e301e5: chore(@dpc-sdp/ripple-ui-core): 💄 update styles on feedback
Project ripple-framework
Branch Review fix/sd-423-breadcrumb-feedback
Run status status check passed Passed #2426
Run duration 09m 33s
Commit git commit e552e301e5: chore(@dpc-sdp/ripple-ui-core): 💄 update styles on feedback
Committer Jason Smith
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 214
View all changes introduced in this branch ↗︎

@waitingallday waitingallday added this to the 2.22.0 milestone Dec 5, 2024
@dylankelly dylankelly merged commit 94ccbde into release/2.22.0 Dec 5, 2024
15 checks passed
@dylankelly dylankelly deleted the fix/sd-423-breadcrumb-feedback branch December 5, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffdowdle jeffdowdle jeffdowdle approved these changes

@dylankelly dylankelly dylankelly approved these changes

@lambry lambry Awaiting requested review from lambry

Assignees

@waitingallday waitingallday

Labels
None yet
Projects
None yet
Milestone
2.22.0
Development

Successfully merging this pull request may close these issues.
3 participants
@waitingallday @dylankelly @jeffdowdle