Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SD-490] Added hover state to pin clusters on maps #1397

Merged
merged 3 commits into from
Dec 8, 2024

Conversation

jeffdowdle
Copy link
Contributor

Issue: https://digital-vic.atlassian.net/browse/SD-490

Screen.Recording.2024-12-06.at.10.15.02.am.mov

What I did

  • Refactored the cluster style code to a single function because the text styles and circle are linked, this allows reliable reuse for the hover state too
  • Added a subtle hover state to the pin clusters

How to test

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed
  • I've updated the documentation site as needed
  • I have added tests to cover my changes (if not applicable, please state why in a comment)

For new UI components only

  • I have added a storybook story covering all variants
  • I have checked a11y tab in storybook passes
  • I have added cypress component tests (if the component is interactive)
  • Any events are emitted on the event bus using emitRplEvent

@jeffdowdle jeffdowdle changed the base branch from develop to release/2.22.0 December 5, 2024 23:16
Copy link

netlify bot commented Dec 5, 2024

Deploy Preview for ripple-docs canceled.

Name Link
🔨 Latest commit 6ab9ec1
🔍 Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/67523461c41cc50008045d69

Copy link

cypress bot commented Dec 5, 2024

ripple-framework    Run #2446

Run Properties:  status check passed Passed #2446  •  git commit 07f6da0fdb: Merge branch 'release/2.22.0' into feature/SD-490-cluster-hover
Project ripple-framework
Branch Review feature/SD-490-cluster-hover
Run status status check passed Passed #2446
Run duration 10m 14s
Commit git commit 07f6da0fdb: Merge branch 'release/2.22.0' into feature/SD-490-cluster-hover
Committer Jeffrey Dowdle
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 214
View all changes introduced in this branch ↗︎

@dylankelly dylankelly added this to the 2.22.0 milestone Dec 6, 2024
@jeffdowdle jeffdowdle force-pushed the feature/SD-490-cluster-hover branch from 2606d5e to bef48a1 Compare December 8, 2024 22:21
@jeffdowdle jeffdowdle merged commit 461d51d into release/2.22.0 Dec 8, 2024
14 of 15 checks passed
@jeffdowdle jeffdowdle deleted the feature/SD-490-cluster-hover branch December 8, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants