Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SD-525] Fixed map sidepanel needed a unique id for highlighting #1407

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

jeffdowdle
Copy link
Contributor

Issue: https://digital-vic.atlassian.net/browse/SD-525

What I did

  • Added the elastic id to the result mapping so that we have a reliable unique id to use as a key
  • There's is no longer a need to pass in itemIdObjPath to the JSON blob

How to test

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed
  • I've updated the documentation site as needed
  • I have added tests to cover my changes (if not applicable, please state why in a comment)

For new UI components only

  • I have added a storybook story covering all variants
  • I have checked a11y tab in storybook passes
  • I have added cypress component tests (if the component is interactive)
  • Any events are emitted on the event bus using emitRplEvent

Copy link

cypress bot commented Dec 11, 2024

ripple-framework    Run #2463

Run Properties:  status check passed Passed #2463  •  git commit 110f9252cd: fix(@dpc-sdp/ripple-tide-search): fixed map sidepanel needing a unique id in dat...
Project ripple-framework
Branch Review bugfix/SD-525-map-sidepanel-highlight
Run status status check passed Passed #2463
Run duration 11m 07s
Commit git commit 110f9252cd: fix(@dpc-sdp/ripple-tide-search): fixed map sidepanel needing a unique id in dat...
Committer Jeffrey Dowdle
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 214
View all changes introduced in this branch ↗︎

@dylankelly dylankelly added this to the 2.23.0 milestone Dec 12, 2024
@jeffdowdle jeffdowdle merged commit 5d47776 into release/2.23.0 Dec 12, 2024
6 checks passed
@jeffdowdle jeffdowdle deleted the bugfix/SD-525-map-sidepanel-highlight branch December 12, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants